75 add a progress callback for reads and writes #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te ops of a LayeredFile or PhotoshopFile in order to track long running tasks more efficiently
…ounting for the ProgressCallback parameter
… functions or create wrappers if not possible
…using just a filename requiring a path prefix
…ery the state of read/write ops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a progress callback which can optionally be attached to a
LayeredFile<T>::readorLayeredFile<T>::writeoperation to asynchronously query the state of those tasks. This is especially useful for long operations on a large file or over a slow network connection.This is currently only implemented on the C++ side but I would appreciate if someone would take the time to implement this on the python side too.
I have also added an example called ProgressCallbacks to illustrate how this can be used.
Fixes regression where passing a simple filename to either read or write (i.e. "OutputFile.psd" rather than "./OutputFile.psd") would cause a crash