Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ARM based Mac chips #61

Open
EmilDohne opened this issue Mar 7, 2024 · 2 comments
Open

Add support for ARM based Mac chips #61

EmilDohne opened this issue Mar 7, 2024 · 2 comments
Assignees
Labels
build good first issue Good for newcomers mac Mac based issues

Comments

@EmilDohne
Copy link
Owner

This appears to only fail on compilation of our AVX2 intrinsics which we can simply opt out of if we detect arm based machines and in the future we can add arm based intrinsics

@EmilDohne EmilDohne added good first issue Good for newcomers build labels Mar 7, 2024
@EmilDohne EmilDohne self-assigned this Mar 7, 2024
@EmilDohne EmilDohne added the mac Mac based issues label Mar 7, 2024
EmilDohne added a commit that referenced this issue Mar 7, 2024
…sing a regular endian decode/encode for arm based systems
@EmilDohne
Copy link
Owner Author

Initial support for this has been added but unfortunately due to issues with GCC and Xcode15 we cannot run the tests as expected failures which throw std::runtime_error() instead segfault the processes. The tests up to the expected failures do run properly which is why we will temporarily add a workaround for these disabling them at compile time. This is unfortunate as it reduces test robustness but until a fix is implemented this will have to be the implementation

@EmilDohne
Copy link
Owner Author

As I am adding support for this the same issues propagate to the python bindings when using e.g. a

try:

except RuntimeError:

code block as ARM-based macs will segfault here as well. Despite support for this being added this ticket will remain open until we find a solution to this problem (likely just waiting for xcode updates to propagate to gh runners)

@EmilDohne EmilDohne mentioned this issue Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build good first issue Good for newcomers mac Mac based issues
Projects
None yet
Development

No branches or pull requests

1 participant