Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock regression #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions .github/workflows/localization.yml

This file was deleted.

Binary file modified Wikipedia.xcarchive.zip
Binary file not shown.
8 changes: 8 additions & 0 deletions Wikipedia.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -3264,6 +3264,8 @@
D8FAC7DD1D6F88AB00C2A6BC /* WMF.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = D844D96C1D6CB2600042D692 /* WMF.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
D8FEECCD1DE3729400B883F0 /* WMFChange.m in Sources */ = {isa = PBXBuildFile; fileRef = D8FEECCC1DE3729400B883F0 /* WMFChange.m */; };
E1CFD6E6210C103900D8E37C /* ExploreCardViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 83CA612920D1675800EF0C4A /* ExploreCardViewController.swift */; };
F30DEFF12858E7190082A645 /* model.json in Resources */ = {isa = PBXBuildFile; fileRef = F30DEFF02858E7190082A645 /* model.json */; };
F3980A7E2858E58800740D4D /* Landscape-Color.jpeg in Resources */ = {isa = PBXBuildFile; fileRef = F3980A7D2858E58800740D4D /* Landscape-Color.jpeg */; };
FF2090F02500247100849774 /* ThreeLineHeaderView.swift in Sources */ = {isa = PBXBuildFile; fileRef = FF2090EE2500247100849774 /* ThreeLineHeaderView.swift */; };
FF2B2110254B7D6A0009E61A /* ActivityIndicatorCollectionViewFooter.swift in Sources */ = {isa = PBXBuildFile; fileRef = FF2B210F254B7D6A0009E61A /* ActivityIndicatorCollectionViewFooter.swift */; };
FF2B2111254B7D6A0009E61A /* ActivityIndicatorCollectionViewFooter.swift in Sources */ = {isa = PBXBuildFile; fileRef = FF2B210F254B7D6A0009E61A /* ActivityIndicatorCollectionViewFooter.swift */; };
Expand Down Expand Up @@ -5245,6 +5247,8 @@
D8FFF6922031CB3D00A028E0 /* my */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = my; path = my.lproj/Localizable.stringsdict; sourceTree = "<group>"; };
D8FFF6932031CB3E00A028E0 /* cy */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = cy; path = cy.lproj/Localizable.stringsdict; sourceTree = "<group>"; };
D8FFF6942031CB4000A028E0 /* tcy */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = tcy; path = tcy.lproj/Localizable.stringsdict; sourceTree = "<group>"; };
F30DEFF02858E7190082A645 /* model.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = model.json; sourceTree = "<group>"; };
F3980A7D2858E58800740D4D /* Landscape-Color.jpeg */ = {isa = PBXFileReference; lastKnownFileType = image.jpeg; path = "Landscape-Color.jpeg"; sourceTree = "<group>"; };
FF0261872627B2D800CBD55F /* kcg */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = kcg; path = kcg.lproj/InfoPlist.strings; sourceTree = "<group>"; };
FF19C1AB260548FD000AC20B /* kcg */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = kcg; path = kcg.lproj/Localizable.strings; sourceTree = "<group>"; };
FF19C1AC26054909000AC20B /* kcg */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = kcg; path = kcg.lproj/Localizable.stringsdict; sourceTree = "<group>"; };
Expand Down Expand Up @@ -8120,6 +8124,7 @@
BC7C3A371C0FF94A0057F023 /* Code */ = {
isa = PBXGroup;
children = (
F3980A7D2858E58800740D4D /* Landscape-Color.jpeg */,
D84C36461F32485E00895FA1 /* Model */,
D818D37F1ED725240076110D /* View Controllers */,
D83F5C051F0E5111006130FF /* Views */,
Expand Down Expand Up @@ -8474,6 +8479,7 @@
isa = PBXGroup;
children = (
D4991453181D51DE00E6073C /* Images.xcassets */,
F30DEFF02858E7190082A645 /* model.json */,
BC7C3A371C0FF94A0057F023 /* Code */,
BCF012321AD2FA38008D3675 /* assets */,
D8BA1F1F1DF1E19700502877 /* Resources */,
Expand Down Expand Up @@ -9820,6 +9826,7 @@
7ABE17292239BB54006BA309 /* WelcomePanelViewController.xib in Resources */,
7ADF498C21B45E42009EA338 /* TextFormattingGroupedToolbarView.xib in Resources */,
D8D92B651DF22E1700B95311 /* [email protected] in Resources */,
F3980A7E2858E58800740D4D /* Landscape-Color.jpeg in Resources */,
6782DBF5234537CF003FA21B /* DiffHeaderExtendedView.xib in Resources */,
7A25367C21B5AA4F00F841A1 /* ContextualHighlightEditToolbarView.xib in Resources */,
B0EFCD681EBEC2F6008F36E5 /* LibrariesUsed.storyboard in Resources */,
Expand All @@ -9840,6 +9847,7 @@
B0E8040B1C0CDE480065EBC0 /* WMFAccountCreationViewController.storyboard in Resources */,
D8D92B621DF22E1700B95311 /* NotificationBackgroundSuccessIcon.png in Resources */,
7AE1FE3621B4A9790068BE9F /* TextFormattingButtonView.xib in Resources */,
F30DEFF12858E7190082A645 /* model.json in Resources */,
B02B82761C696ECA00B19309 /* WMFSettingsTableViewCell.xib in Resources */,
D8D92B671DF22E1700B95311 /* [email protected] in Resources */,
D84692E11D5E1E3F000A7058 /* TableOfContentsHeader.xib in Resources */,
Expand Down
10 changes: 10 additions & 0 deletions Wikipedia/Code/AppDelegate.m
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ @interface AppDelegate ()

@property (nonatomic, strong) WMFAppViewController *appViewController;
@property (nonatomic) BOOL appNeedsResume;
@property (nonatomic) NSDictionary *model;

@end

Expand Down Expand Up @@ -86,12 +87,21 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
[UNUserNotificationCenter currentNotificationCenter].delegate = vc; // this needs to be set before the end of didFinishLaunchingWithOptions:
[vc launchAppInWindow:self.window waitToResumeApp:self.appNeedsResume];
self.appViewController = vc;
[self loadModel];

[self updateDynamicIconShortcutItems];

return YES;
}

// An artificial "regression" added, where we do a common startup task (JSON parsing)
- (void)loadModel
{
NSString *path = [[NSBundle mainBundle] pathForResource:@"model" ofType:@"json"];
NSData *data = [NSData dataWithContentsOfFile:path];
self.model = [NSJSONSerialization JSONObjectWithData:data options:0 error:nil];
}

- (void)applicationWillEnterForeground:(UIApplication *)application {
// Called as part of the transition from the background to the inactive state; here you can undo many of the changes made on entering the background.
[self cancelPendingBackgroundTasks];
Expand Down
Binary file added Wikipedia/Code/Landscape-Color.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions Wikipedia/model.json

Large diffs are not rendered by default.

24 changes: 0 additions & 24 deletions upload.rb

This file was deleted.