Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/buffer head #378

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Aug 28, 2023

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

Thanks to this PR framed transport should be able to store header data in message buffer and all data can be send to other side at once. So far not tested.

!!!!! Please review and merge this PR: #373

To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS:
  • eRPC Version:

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.
  • Allow edits from maintainers pull request option is set (recommended).

Additional context

@Hadatko
Copy link
Member Author

Hadatko commented Aug 28, 2023

@amgross @MichalPrincNXP First non tested version for serializing and deserializing header data in MessageBuffer. What do you think? I will try to think if we can simplify things, but there is many scenario we need count with

@Hadatko
Copy link
Member Author

Hadatko commented Aug 28, 2023

Hmm tests are not passing, need to see where i have an issue.

@Hadatko
Copy link
Member Author

Hadatko commented Aug 28, 2023

It looks like i will need to do more massive changes (replacing * with &). But test should pass now.

@Hadatko
Copy link
Member Author

Hadatko commented Sep 19, 2023

Almost ready. Now i want transform tty driver to be part of framed transport and improve frametransport to be able to receive message at one message.

@Hadatko
Copy link
Member Author

Hadatko commented Sep 20, 2023

@MichalPrincNXP Could you start with reviewing? As tests are passing most transport should work. What could be an issue are RPMSG related transports. I will try rpmsg tty implemenattion, but it would be great if you can some other rpmsg implementation on your side.

@Hadatko Hadatko force-pushed the feature/bufferHead branch 2 times, most recently from 0df0a3b to fcac1c4 Compare September 20, 2023 12:25
@Hadatko
Copy link
Member Author

Hadatko commented Sep 21, 2023

@MichalPrincNXP I provided simple fix for rpmsg tty. Tested on board. What i cannot test is MU and other RPMSG transports. Could you try at least some of them (e.g. MU). It would be great if we can confirm at least compilation for all of them and running test for at least one of them (e.g. MU)

!!! removed one mbf file and one file renamed.

Signed-off-by: Cervenka Dusan <[email protected]>
Signed-off-by: Cervenka Dusan <[email protected]>
@Hadatko
Copy link
Member Author

Hadatko commented Oct 18, 2023

Hi @MichalPrincNXP , as promissed PR rebased to the top...

@Hadatko Hadatko added this to the 1.12.0 milestone Oct 18, 2023
Signed-off-by: Cervenka Dusan <[email protected]>
Signed-off-by: Cervenka Dusan <[email protected]>
@MichalPrincNXP MichalPrincNXP merged commit 958569b into EmbeddedRPC:develop Oct 24, 2023
7 checks passed
@MichalPrincNXP
Copy link
Member

thank you, Dusan

@Hadatko Hadatko deleted the feature/bufferHead branch October 24, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment