Remove CPU limits rule #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For most use cases setting a CPU limit can be detrimental for performance, especially when serving requests over the network as it impacts tail latencies. Also there seems to have been some copy-pasta error where the rule denying SYS_ADMIN capability was using the same check code K8S_08. I switched so that it uses K8S_05 which seemed to be unclaimed.
Illedran
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
For most use cases setting a CPU limit can be detrimental for
performance, especially when serving requests over the network as it
impacts tail latencies.
Also there seems to have been some copy-pasta error where the rule
denying SYS_ADMIN capability was using the same check code K8S_08. I
switched so that it uses K8S_05 which seemed to be unclaimed.
Also updated CODEOWNERS