Github CI to test metrics integration #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvin319
approved these changes
Sep 7, 2023
calculate_metrics.py
Outdated
| @@ -242,7 +258,7 @@ def main(): | |||
|
|
|||
| for data_scheme in args.schemes if isinstance(args.schemes, list) else args.schemes.split(","): | |||
| LOGGER.info("Loading pre-computed features...") | |||
| precomputed_features = load_precomputed_features(data_scheme) | |||
| precomputed_features = load_precomputed_features(data_scheme, is_test = str(args.datasets) == "test") | |||
There was a problem hiding this comment.
I think we should just put this loop for dataset_name in args.datasets if isinstance(args.datasets, list) else args.datasets.split(",") right outside of the data_scheme loop, then we can calculate is_test directly off of the right dataset_name.
The current implementation would only work if we only run on test datasets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds github CI to test metrics integration
For now, we trigger it manually. Can be automated if required later...