Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding _warmup_mmap_file function missing from MMapIndexedDataset #148

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Adding _warmup_mmap_file function missing from MMapIndexedDataset #148

merged 1 commit into from
Feb 22, 2024

Conversation

rdiehlmartinez
Copy link
Contributor

_warmup_mmap_file function copied over from fairseq. Seems to be missing from mmap_dataset

@rdiehlmartinez
Adding _warmup_mmap_file function missing from MMapIndexedDataset
76eca24 
_warmup_mmap_file function copied over from fairseq
@CLAassistant
Copy link

CLAassistant commented Feb 1, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

haileyschoelkopf
haileyschoelkopf approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@haileyschoelkopf haileyschoelkopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, approved!

@haileyschoelkopf haileyschoelkopf merged commit 1b4ffc3 into EleutherAI:main Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyschoelkopf haileyschoelkopf haileyschoelkopf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rdiehlmartinez @CLAassistant @haileyschoelkopf