adding tutorial docs for DataParallel, ZeroOptimizer #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunwoongko
reviewed
Apr 5, 2023
| model = model.to("cuda") | ||
| # create optimizer | ||
| optimizer = ZeroRedundancyOptimizer( | ||
| Adam(model.parameters(), lr=3e-5), |
There was a problem hiding this comment.
@jinwonkim93 @nijkah @KKIEEK @yhna940
How about using initializer parameters like model parameters, lr, optimizer class separately like this?
optimizer = ZeroOptimizer(
optimizer_class=Adam,
params=model.parameters(),
lr=3e-5,
weight_decay=5e-7,
... (other params) ...
)There was a problem hiding this comment.
why do you want to separate them?
|
@jinwonkim93 작업 끝나시면 말씀해주세요! |
|
|
보내드린거 확인 부탁드려요~ |
jinwonkim93
changed the title
dyanos
pushed a commit
that referenced
this pull request
Jun 8, 2023
## Title - Add tutorial docs for DataParallel, ZeroOptimizer. ## Description - ## Linked Issues - resolved #00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Description
Linked Issues