refactor paths #76
Merged
refactor paths #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rk1a
approved these changes
Jul 31, 2023
minetester/minetest_env.py
Outdated
| shape=(self.display_size[1], self.display_size[0], 3), | ||
| dtype=np.uint8, | ||
| ) | ||
| self._configure_obs_space() |
There was a problem hiding this comment.
alternative name suggestion: _configure_spaces()
minetester/minetest_env.py
Outdated
| if self.config_path is None: | ||
| self.config_path = os.path.join(self.root_dir, f"{self.unique_env_id}.conf") | ||
| self._set_artefact_dirs(artefact_dir, world_dir, config_path, config_dict) #Stores minetest artefacts and outputs | ||
| self._set_minetest_folders(minetest_root) #Stores actual minetest dirs and executable |
There was a problem hiding this comment.
alternative name suggestion: _set_minetest_dirs
| ) | ||
|
|
||
| def _set_artefact_dirs(self, artefact_dir, world_dir, config_path, config_dict): | ||
| if artefact_dir is None: |
There was a problem hiding this comment.
can be shortened self.artefact_dir = artefact_dir or other_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compact, short information about your PR for easier understanding:
-This PR refactors how paths are instantiated and discovered both for the minetest executable and the minetester python package
To do
Ready for Review
--cacheflag to specify location of the media cache directory--cache flagin minetesterHow to test
run readme up to make demo, both with a local install and wheel install, verify that no directories are created outside of the
artefactsdirectory and that the wheel binary is being used.