Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build automation #70

Merged
merged 12 commits into from
Jul 20, 2023
Merged

Build automation #70

merged 12 commits into from
Jul 20, 2023

Conversation

AI-WAIFU
Copy link

@AI-WAIFU AI-WAIFU commented Jul 14, 2023

Add compact, short information about your PR for easier understanding:

This PR adds build automation in the form of a make file it is intended to replace build_instructions.txt

To do

This PR is a Work in Progress

  • end-to-end buld
  • add readme documentation for the build instructions
  • fix makefile dependencies
  • end-to-end testing

How to test

Get a fresh copy of ubuntu
Install minetester according to instructions in README

@AI-WAIFU AI-WAIFU marked this pull request as ready for review July 15, 2023 22:30
Copy link

@rk1a rk1a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very useful PR for simplifying the build process and distributing the minetester package.

There are two TODOs that I think follow from this:

  • adapt Minetest environment class to use the shipped binaries by default and allow loading files and mods from arbitrary directories (drop the assumption that env is run from the minetest repo)
  • set up a github actions pipeline for this build process

minetest.conf Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
util/minetester/build_minetest.sh Outdated Show resolved Hide resolved
util/minetester/build_minetest.sh Outdated Show resolved Hide resolved
util/minetester/clean.sh Show resolved Hide resolved
util/minetester/clean.sh Show resolved Hide resolved
@AI-WAIFU AI-WAIFU merged commit 908ec01 into develop Jul 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants