Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the protobuf version in setup.py #64

Merged
merged 1 commit into from
May 28, 2023
Merged

Update the protobuf version in setup.py #64

merged 1 commit into from
May 28, 2023

Conversation

JJJHolscher
Copy link

setup.py specified a wrong version for protobuf (3.19.0). This resulted in an import error.
Here is the updated version (3.20.1).

other small changes:

  • README.md now mentions build_instructions.txt.
  • build_instructions.txt now explicitly mentions calling pip install -e ./minetest

@CLAassistant
Copy link

CLAassistant commented May 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JJJHolscher JJJHolscher mentioned this pull request May 26, 2023
Closed
Rabbidon

This comment was marked as duplicate.

Sign in to view

Rabbidon
Rabbidon approved these changes May 28, 2023
View reviewed changes
Copy link

@Rabbidon Rabbidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rabbidon Rabbidon merged commit 41126ad into EleutherAI:develop May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rabbidon Rabbidon Rabbidon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JJJHolscher @CLAassistant @Rabbidon