Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve world seeding and config handling #61

Merged
merged 7 commits into from
Aug 29, 2023

Conversation

rk1a
Copy link

@rk1a rk1a commented Mar 26, 2023

  • distinguish between base_seed and world_seed to allow for RNG to generate world seeds from a base seed
  • add utils for minetest config reading/writing
  • allow updating of minetest config entries via provided config file or dict
  • fix a bug related to cleaning up world dirs
  • fix gymnasium implementation

This PR is a Ready for Review.

* base seed is used for a RNG
* world seed directly seeds the map generator
* if no world seed is provided, one is generated from the RNG
* fixed missing done flag in step return
* move worlds and configs to respective folders in the root directory
* use gym async vector env in parallel test loop removing SB3 dependence
@rk1a rk1a requested a review from neverix March 26, 2023 23:11
@CLAassistant
Copy link

CLAassistant commented Apr 23, 2023

CLA assistant check
All committers have signed the CLA.

@AI-WAIFU
Copy link

Can you fix the merge conflicts with the latest develop?

@rk1a rk1a requested a review from AI-WAIFU April 28, 2023 19:52
Copy link

@AI-WAIFU AI-WAIFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, works when tested

@AI-WAIFU AI-WAIFU merged commit d1afd70 into EleutherAI:develop Aug 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants