Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required protobuf version #56

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

rk1a
Copy link

@rk1a rk1a commented Mar 7, 2023

These version specifications are compatible with cleanRL and the protobuf compiler on the cluster.

Ready for Review.

@neverix
Copy link
Member

neverix commented Mar 7, 2023

Might be a problem since VPT requires gym==0.19 and SB3 gym==0.21. I would suggest moving this into an extras_require.

@rk1a
Copy link
Author

rk1a commented Mar 7, 2023

Might be a problem since VPT requires gym==0.19 and SB3 gym==0.21. I would suggest moving this into an extras_require.

Yea, this is problematic.
Though, I think an extras_require would only make sense if we also provide the RL code in minetester.
Can we just require gym without version, and let each library install its required version?

As a side note, the current minetest env is only compatible up to gym==0.22 which introduces the first large change to the API. Code that uses newer gym versions should convert minetest envs, e.g. with compatibility wrappers like the ones available in gym(nasium)>=0.26: https://gymnasium.farama.org/content/gym_compatibility/#gym-v0-22-environment-compatibility

@rk1a rk1a changed the title Update gym and protobuf versions Update required protobuf version Mar 10, 2023
Copy link

@AI-WAIFU AI-WAIFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AI-WAIFU AI-WAIFU merged commit 6aeb83c into EleutherAI:develop Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants