Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Docker container setup for the project #51

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Ryu1845
Copy link

@Ryu1845 Ryu1845 commented Feb 5, 2023

This pull request creates a Docker container setup for the alignment-minetest project. (solves #42)

This PR is a Work in Progress.

To do

  • Working Dockerfile
  • Add build instruction for the container
  • Push to a docker repository (?)
  • Optimize build speed (?)

alignment.Dockerfile Outdated Show resolved Hide resolved
alignment.Dockerfile Outdated Show resolved Hide resolved
alignment.Dockerfile Show resolved Hide resolved
@Ryu1845 Ryu1845 requested a review from rk1a February 6, 2023 19:39

WORKDIR minetest
EXPOSE 30000
CMD ["hacking_testing/server.sh"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this got me wondering, will we need a separate Dockerfile for clients?
If this is specifically for running a server then we actually don't need to build with SDL at all.
On the other hand, I guess initially we will have server and client(s) running on the same machine, maybe even the same docker container..
So in case of a single Dockerfile it probably would make sense to not hardcode the entry point here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMD is just a default, we could make a cli with support for the different options as an entry point maybe?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that sounds good. even simpler: optionally pass a any script that is being used as entrypoint

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants