Add image + action recording #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rk1a
commented
Dec 31, 2022
src/client/client.cpp
Outdated
| @@ -1891,6 +1891,18 @@ void Client::makeScreenshot() | |||
| raw_image->drop(); | |||
| } | |||
|
|
|||
| float Client::getReward() { | |||
| float reward = 0.0; | |||
| //ClientScripting *scr = getScript(); | |||
There was a problem hiding this comment.
This is commented because it is throwing LUA errors. @neverix I guess this is because I don't have the reward mod installed that you used?
There was a problem hiding this comment.
Probably, maybe the issue is in the config
neverix
approved these changes
Dec 31, 2022
this is to load config, mods etc. from the minetest folder instead of user's home folder
This was referenced Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds action recording
To do
This PR is a Work in Progress
How to test
bash hacking_testing/server.shbash hacking_testing/record_client.shpython data_recorder.py