add README note and fix FindZmqpp.cmake

EleutherAI · Jan 23, 2023 · 2cbbbe1 · 2cbbbe1
1 parent e763851
commit 2cbbbe1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -172,6 +172,9 @@ For Alpine users (unsupported):
 
  sudo apk add build-base cmake libpng-dev jpeg-dev libxi-dev mesa-dev sqlite-dev libogg-dev libvorbis-dev openal-soft-dev curl-dev freetype-dev zlib-dev gmp-dev jsoncpp-dev luajit-dev zstd-dev
 
+
+Note that libzmqpp-dev or it's equivalent dependency may be unavailble, in that case libzmqpp needs to be compiled manually by initializing and building the submodule in lib/zmqpp.
+
 #### Download
 
 You can install Git for easily keeping your copy up to date.

diff --git a/cmake/Modules/FindZmqpp.cmake b/cmake/Modules/FindZmqpp.cmake
@@ -32,9 +32,9 @@ if(NOT USE_SYSTEM_ZMQPP)
  message(${ZMQPP_LIBRARY})
 
  if(ZMQPP_LIBRARY AND ZMQPP_INCLUDE_DIR)
- message (STATUS "Using ZMQPP provided by the submodule.")
+ message(STATUS "Using ZMQPP provided by the submodule.")
  else()
- message (STATUS "ZMQPP submodule detection failed, please navigate to lib/zmqpp, initialize the submodule with \"git submodule update --init\", and then use \"make\" to build zmqpp")
+ message(FATAL_ERROR "ZMQPP submodule detection failed, please navigate to lib/zmqpp, initialize the submodule with \"git submodule update --init\", and then use \"make\" to build zmqpp")
  endif()
 endif()
 include(FindPackageHandleStandardArgs)