-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chat template #1873
Add chat template #1873
Conversation
@KonradSzafer fix the linting please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @KonradSzafer for bearing with me!
had a couple other small comments about edge cases, but in general, looks really great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final round of comments! Will also add a docs update to docs/model_guide.md imminently.
May I suggest template actually used to be reported in some artifacts from run (with or without |
Add docs on Chat Template interface to `docs/model_guide.md`
Hi @LSinev! Good point, updated the branch with the changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for all your work on this :)
Co-authored-by: Hailey Schoelkopf <[email protected]>
What do you think, models should be tested with argument |
Hi @djstrong! |
I tested this only for one model and I confirm that with I have tested dozen of models with and without chat templates but need to analyze results. Available here: https://huggingface.co/spaces/speakleash/open_pl_llm_leaderboard with |
This pull request adds a chat template that allows a few examples to be provided as a conversation between user and assistant, or as a single message from the user, as well as providing a system prompt.
@clefourrier @NathanHB