remove echo parameter in OpenAI completions API #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djstrong
requested review from
haileyschoelkopf and
lintangsutawika
as code owners
haileyschoelkopf
approved these changes
May 5, 2024
notrichardren
pushed a commit
to steven-basart/lm-evaluation-harness
that referenced
this pull request
May 31, 2024
* remove echo parameter in OpenAI completions API * remove context length parameter doc string
|
This change looks dangerous. OpenAI may have deprecated the echo param, but vllm still maintains a completions api which supports echo and outputs prompt logits. With this change, local_completions would be scored wrongly, isn't it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #1704