Group agg rework #1741
Open
Group agg rework #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oup aggregate in general
…rness into group-agg-rework
|
@haileyschoelkopf I've only added the |
haileyschoelkopf
requested changes
Jun 7, 2024
There was a problem hiding this comment.
Very close to done!
Left some comments, and messaged you re: how we should perhaps change the GroupConfig interface
Other than that:
- we should go through and determine which of existing groups should be aggregating and which should not. I can do this
- I need to go through again more finely the evaluator.py changes, there's quite a lot of logic in there at this point that I want to look more closely at
- We should couple this with a readme update mentioning this change + referring people to Discord and the docs files for better understanding what's affected.
Will try to aim for having this merged by end of next week. Sorry for all the delays!
| @@ -242,7 +242,7 @@ def get_original(self, newarr): | |||
| return res | |||
|
|
|||
|
|
|||
| def make_table(result_dict, column: str = "results", sort_results: bool = True): | |||
| def make_table(result_dict, column: str = "results", sort_results: bool = False): | |||
There was a problem hiding this comment.
reason for not sorting by default?
There was a problem hiding this comment.
It messes up the group name, as in the group name also gets sorted.
| @@ -0,0 +1,45 @@ | |||
| group: test-1 | |||
There was a problem hiding this comment.
is there an assorted test for this? Note also #1916 should help with PRs like this
Co-authored-by: Hailey Schoelkopf <[email protected]>
Co-authored-by: Hailey Schoelkopf <[email protected]>
Co-authored-by: Hailey Schoelkopf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
group_configwill need to be defined in the yaml that consists ofaggregate_metric(True/False, default False) andweight_by_size(True/False, default False).task_idinConfigurableGroupandConfigurableTaskto be used as identifier in lieu of task name/group name.