Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch size needs to be specified #87

Merged
merged 1 commit into from
Jan 23, 2021
Merged

Batch size needs to be specified #87

merged 1 commit into from
Jan 23, 2021

Conversation

joshlk
Copy link
Member

@joshlk joshlk commented Jan 23, 2021

Small change so config/gpt3_small.json works

@joshlk joshlk requested a review from a team as a code owner January 23, 2021 19:24
StellaAthena
StellaAthena approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@StellaAthena StellaAthena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if you don't use the ZeRO optimizer, yes this is needed. Do keep in mind that the ZeRO optimizer ignores this and uses the value in the deepspeed config file.

@StellaAthena StellaAthena merged commit efd1ad8 into main Jan 23, 2021
@StellaAthena StellaAthena deleted the gtp3_small branch January 23, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StellaAthena StellaAthena StellaAthena approved these changes

@ConnorJL ConnorJL Awaiting requested review from ConnorJL

@sdtblck sdtblck Awaiting requested review from sdtblck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshlk @StellaAthena