Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fused kernel error recommendation, and make error logs more verbose #824

Merged
merged 7 commits into from
Mar 14, 2023

Conversation

Quentin-Anthony
Copy link
Member

This PR makes two small changes:

  • Sometimes the python megatron/fused-kernels/setup.py install will fail with errors that pip install megatron/fused-kernels will not cause (e.g. a nasty undefined torch symbol that I encountered today). I therefore updated the error message to recommend pip install instead.
  • Failing to import a fused kernel can be due to many issues (i.e. broken install) besides the kernels not being installed, so we should print the specific error as well.

@StellaAthena StellaAthena self-requested a review March 14, 2023 19:13
@StellaAthena StellaAthena merged commit 382ee7d into main Mar 14, 2023
@StellaAthena StellaAthena deleted the fused-kernels-msg branch March 14, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants