Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small changes for MosaicML cloud usage #778

Merged
merged 15 commits into from
Feb 3, 2023
Merged

Small changes for MosaicML cloud usage #778

merged 15 commits into from
Feb 3, 2023

Conversation

dakinggg
Copy link
Contributor

This PR adds a JSON compatible config file, and support for GPT2Dataset to work on multi node, without a shared file system.

Pairs with EleutherAI/DeeperSpeed#44

@dakinggg dakinggg requested a review from a team as a code owner January 27, 2023 21:18
@dakinggg dakinggg mentioned this pull request Jan 27, 2023
Merged
haileyschoelkopf
haileyschoelkopf approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@haileyschoelkopf haileyschoelkopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @Quentin-Anthony I think we can merge this

@Quentin-Anthony Quentin-Anthony merged commit 0c831c3 into EleutherAI:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyschoelkopf haileyschoelkopf haileyschoelkopf approved these changes

@Quentin-Anthony Quentin-Anthony Quentin-Anthony approved these changes

@StellaAthena StellaAthena Awaiting requested review from StellaAthena StellaAthena was automatically assigned from EleutherAI/pm-gptneo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakinggg @Quentin-Anthony @haileyschoelkopf