Optimize data preprocessing by using numpy #771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to accelerate
preprocess_data.py
. There are mainly 2 optimizations:numpy.ndarray
toadd_item
ofIndexDatasetBuilder
to avoid an immediatetensor.numpy()
.np.cumsum
instead of a loop to calculate the pointer offsets.Thank you for your time on reviewing this PR :)