Slurm Fix and formatting #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt has been added to DeeperSpeed. Necessary for Stability cluster Signed-off-by: Dashiell Stander <[email protected]>
Signed-off-by: Dashiell Stander <[email protected]>
Signed-off-by: Dashiell Stander <[email protected]>
Signed-off-by: Dashiell Stander <[email protected]>
Signed-off-by: Dashiell Stander <[email protected]>
|
Most of the changed files were made by pre-commit hooks. Was a new one added recently? I can go back and revert them to make things cleaner. |
Signed-off-by: Dashiell Stander <[email protected]>
We're using the same pre-commit hooks, but I've forgotten to enforce the pre-commit hooks for some recent PRs. Just update the PR to "Slurm Fix and formatting" and we'll pull both together. |
Quentin-Anthony
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes lingering bug in Slurm implementation. Paired with this PR in DeeperSpeed. Changes
slurm_commentcommand line argument to justcommentand ensures that aMASTER_ADDRenvironment variable is properly passed to Deep(er)Speed.Also runs the pre-commit formatting checks.