Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix learned and sinusoidal embeddings after OPT regression #722

Merged
merged 12 commits into from
Jan 18, 2023
Merged

Fix learned and sinusoidal embeddings after OPT regression #722

merged 12 commits into from
Jan 18, 2023

Conversation

Quentin-Anthony
Copy link
Member

Fixes #721

@zphang -- Can you test this with OPT?

@StellaAthena -- FYI

@Quentin-Anthony Quentin-Anthony requested a review from a team as a code owner November 27, 2022 21:08
@StellaAthena StellaAthena added this to the Release V2 milestone Dec 20, 2022
@StellaAthena
Copy link
Member

@zphang did you ever have a chance to review this?

@dashstander
Copy link
Contributor

I've tested this and it doesn't break anything in the normal workflow @Quentin-Anthony

@StellaAthena StellaAthena merged commit 01f75eb into main Jan 18, 2023
@StellaAthena StellaAthena deleted the opt-embeddings-fix branch January 18, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StellaAthena StellaAthena StellaAthena approved these changes

@ShivanshuPurohit ShivanshuPurohit Awaiting requested review from ShivanshuPurohit ShivanshuPurohit was automatically assigned from EleutherAI/pm-gptneo

@zphang zphang Awaiting requested review from zphang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release V2
Development

Successfully merging this pull request may close these issues.

Broken "learned" embeddings
3 participants
@Quentin-Anthony @StellaAthena @dashstander