Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement gradient checkpointing #59

Merged
merged 2 commits into from
Jan 13, 2021
Merged

implement gradient checkpointing #59

merged 2 commits into from
Jan 13, 2021

Conversation

sdtblck
Copy link
Contributor

@sdtblck sdtblck commented Jan 13, 2021

@StellaAthena i was totally wrong sorry, lol #55

@sdtblck sdtblck requested a review from a team as a code owner January 13, 2021 11:02
ConnorJL
ConnorJL approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@ConnorJL ConnorJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it doesn't work, Sid's fault

@ConnorJL ConnorJL merged commit 9fe917d into main Jan 13, 2021
@ConnorJL ConnorJL deleted the gradient_checkpointing branch January 13, 2021 13:28
@StellaAthena StellaAthena linked an issue Jan 24, 2021 that may be closed by this pull request
Pipeline parallelism and gradient checkpointing (edit: and ZeRO 2!) don’t work together #62
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingoflolz kingoflolz kingoflolz approved these changes

@ConnorJL ConnorJL ConnorJL approved these changes

@StellaAthena StellaAthena Awaiting requested review from StellaAthena

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipeline parallelism and gradient checkpointing (edit: and ZeRO 2!) don’t work together
3 participants
@sdtblck @kingoflolz @ConnorJL