Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Char level ppl #400

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Char level ppl #400

merged 4 commits into from
Aug 31, 2021

Conversation

sdtblck
Copy link
Contributor

@sdtblck sdtblck commented Aug 31, 2021

Sorry, my autoformatter went ham.
Probably not the worst thing.

Relevant changes are:

@sdtblck sdtblck requested a review from a team as a code owner August 31, 2021 13:09
sweinbach
sweinbach previously approved these changes Aug 31, 2021
@StellaAthena
Copy link
Member

I have resolved the conflicts with main. @sweinbach can you confirm that this doesn't introduce bugs for whatever reason?

@sdtblck
Copy link
Contributor Author

sdtblck commented Aug 31, 2021

@StellaAthena I tested again, works fine. Can you reapprove?

@sdtblck sdtblck enabled auto-merge (squash) August 31, 2021 17:20
@EricHallahan EricHallahan self-requested a review August 31, 2021 17:21
@sdtblck sdtblck merged commit e3cf7a6 into main Aug 31, 2021
@sdtblck sdtblck deleted the char_level_ppl branch August 31, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants