Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added madgrad_wd optimizer from https://github.com/lessw2020/Best-Dee… #288

Merged
merged 2 commits into from
May 3, 2021

Conversation

preethamgali
Copy link
Member

As per the request #210 madgrad_wd from https://github.com/lessw2020/Best-Deep-Learning-Optimizers is added to the optimizers list.

@preethamgali preethamgali requested a review from a team as a code owner May 3, 2021 15:08
@sdtblck
Copy link
Contributor

sdtblck commented May 3, 2021

As per the request #210 madgrad_wd from https://github.com/lessw2020/Best-Deep-Learning-Optimizers is added to the optimizers list.

Oh wow, awesome! I'll take a look over this this evening.

@sdtblck
Copy link
Contributor

sdtblck commented May 3, 2021

The code all looks perfect to me. Have you tried it out yet @preethamgali ?
I'm not sure how madgrad handles fp16

@sdtblck
Copy link
Contributor

sdtblck commented May 3, 2021

Working great for me - merging it now. Thanks again @preethamgali

@sdtblck sdtblck merged commit d336ce9 into main May 3, 2021
@sdtblck sdtblck deleted the gpt-neox-with-madgrad_wd branch May 3, 2021 22:01
@StellaAthena StellaAthena linked an issue May 3, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Madgrad
2 participants