fix small bug where sequence length is not passed into attention class #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StellaAthena
reviewed
Jan 1, 2021
There was a problem hiding this comment.
I tried this code, and it wasn't enough to get the code running on the server. See #22
StellaAthena
approved these changes
Jan 1, 2021
There was a problem hiding this comment.
This allows gpt3small to run, but does not fix the problems with sparse attention (see #22)
StellaAthena
added a commit
that referenced
this pull request
Jan 1, 2021
#21) (#23) * fix small bug where sequence length is not passed into attention class * fix bug with mask and half values, as well as masking in dense attention * make sure install deepspeed with pip sudo This allows `gpt3small` to run but does not fix the problems with sparse attention. See #22 Co-authored-by: Phil Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.