Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you try to use the following
optimizer
andzero_optimizer
settings:You will encounter:
This PR fixes that issue by selecting the correct version of Lion depending on whether zero is enabled.
The current version of DeeperSpeed that's pinned in
requirements.txt
doesn't incorporate the upstream DeepSpeed changes that includeFusedLion
, so a DeeperSpeed version bump is also necessary. Recommend waiting to merge this until EleutherAI/DeeperSpeed#60 is merged and the DeeperSpeed version inrequirements.txt
can be bumped to that merge commit. That PR + this one have been tested for pipeline and tensor parallel training with FusedLion. Verified original behavior (megatron.optimizers.Lion
) inzero_optimizer["stage"] = 0
case.zero_optimizer["stage"] = 1
casezero_optimizer["stage"] = 0
case