Remove gas (beano) #1144
Merged
Remove gas (beano) #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh: And any model run with "gas" set at anything other than "1" will have had batch size smaller by 1/their_gas_size than they intended. People might want to check their previous work for that. |
Quentin-Anthony
approved these changes
Feb 5, 2024
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per code being removed:
This is set in many configs and never assigned from. Its continued existence in neox only encourages people to set
gas, which does apparently nothing, instead of settinggradient_accumulation_steps, which is probably what they intended to do.Pythia configs left alone because the source of truth for those configs is the pythia repo.