Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better run_eval_harness import #1139

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Better run_eval_harness import #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
moved eval import and added to docs
  • Loading branch information
@R0n12
R0n12 committed Jan 29, 2024
commit 9bed5471208f18b82fc50f5efc1a55f7b0b49a37
9 changes: 5 additions & 4 deletions configs/neox_arguments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,7 +976,7 @@ Text Generation arguments

- **prompt_end**: str

Default =
Default =


a single prompt's end. Defaults to newline
Expand Down Expand Up @@ -1018,7 +1018,7 @@ Text Generation arguments

- **eval_results_prefix**: str

Default =
Default =

prefix to which to save evaluation results - final fp will be {eval_results_prefix}_eval_results_yy-mm-dd-HH-MM.json

Expand All @@ -1030,6 +1030,8 @@ Text Generation arguments

Tasks to evaluate on using lm_eval_harness

NOTE: Requires internet connection



## NeoXArgsTokenizer
Expand Down Expand Up @@ -1768,7 +1770,7 @@ Args for deepspeed config

Default = None





Expand Down Expand Up @@ -2068,4 +2070,3 @@ Args for deepspeed runner (deepspeed.launcher.runner).
Default = None

Adds a `--account` to the DeepSpeed launch command. In DeeperSpeed this is passed on to the SlurmLauncher as well. Sometimes necessary for cluster rules, or so I've heard.

3 changes: 2 additions & 1 deletion megatron/training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
CharCounter,
)
from megatron.model.gpt2_model import cross_entropy
from eval_tasks import run_eval_harness


def mup_weights_reinit(neox_args, model):
Expand Down Expand Up @@ -967,6 +966,8 @@ def evaluate(
)

if neox_args.eval_tasks:
from eval_tasks import run_eval_harness

eval_results.update(
run_eval_harness(
model, forward_step_fn, neox_args, eval_tasks=neox_args.eval_tasks
Expand Down
Loading