Minor changes #1125
Merged
Minor changes #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
segyges
commented
Jan 19, 2024
segyges
commented
- Changes default output for docker container
- Renames docker pythia config to indicate it is docker pythia config
- Fix unit test for evaluate function
tests/README.md
Outdated
|
|
||
| # run tests in tests/model, output coverage report of megatron module as html | ||
| pytest --forked --cov-report html --cov=megatron tests/model |
There was a problem hiding this comment.
Why the removal of --forked? These should be necessary for distributed pytests.
There was a problem hiding this comment.
--forked is causing this error, a lot:
RuntimeError: Cannot re-initialize CUDA in forked subprocess. To use CUDA with multiprocessing, you must use the 'spawn' start method
Removing it resolves most of those; it's possible it would be better to figure out why the runner fails in this way presently, though.
There was a problem hiding this comment.
@Quentin-Anthony I pulled the bit about --forked out, resolving whatever is going on with tests can be pushed to a different issue/PR.
This reverts commit 19021fc.
This makes it so that git doesn't try to let you commit (or force you to stash) data files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.