Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy_k8s.sh #102

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Update deploy_k8s.sh #102

merged 1 commit into from
Jan 27, 2021

Conversation

leogao2
Copy link
Contributor

@leogao2 leogao2 commented Jan 27, 2021

No description provided.

@leogao2 leogao2 requested a review from a team as a code owner January 27, 2021 18:17
@joshlk
Copy link
Member

joshlk commented Jan 27, 2021

Do you think its worth setting up a CI pipeline that builds the docker image uploads it to a EleutherAI account. Otherwise each time we change the code (e.g. requirements.txt) we will need to prompt you @leogao2? I have done this before and can help

@leogao2
Copy link
Contributor Author

leogao2 commented Jan 27, 2021

@joshlk Agree that we should do that eventually, this is just a stopgap. If you want to work on a CI pipeline that would be great.

Also, another problem with CI pipelines is that the build could potentially take quite some time, which is not good for fast iteration.

@StellaAthena StellaAthena merged commit 39972e6 into main Jan 27, 2021
@StellaAthena StellaAthena deleted the leogao2-patch-1 branch January 27, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants