Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of test file #10

Merged
merged 3 commits into from
Dec 26, 2020
Merged

get rid of test file #10

merged 3 commits into from
Dec 26, 2020

Conversation

sdtblck
Copy link
Contributor

@sdtblck sdtblck commented Dec 26, 2020

No description provided.

@sdtblck sdtblck requested a review from a team as a code owner December 26, 2020 15:01
@sdtblck
Copy link
Contributor Author

sdtblck commented Dec 26, 2020

did some other basic cleanup, removed enwik8 from the repo so it's downloaded on demand, moved util functions to utils, etc.

@StellaAthena StellaAthena linked an issue Dec 26, 2020 that may be closed by this pull request
Integrate DeepSpeed #4
Closed
StellaAthena
StellaAthena reviewed Dec 26, 2020
View reviewed changes
Copy link
Member

@StellaAthena StellaAthena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the changes to trainenwik8.py I’m a little confused by the fact that so many imports were removed despite the code not changing much. Was that just a lot of functionality that wasn’t actually being used?

@sdtblck
Copy link
Contributor Author

sdtblck commented Dec 26, 2020

@StellaAthena imports were leftover from the old code that wasn't using deepspeed

@StellaAthena StellaAthena self-requested a review December 26, 2020 15:47
@StellaAthena StellaAthena merged commit 7759771 into main Dec 26, 2020
@StellaAthena StellaAthena deleted the remove-test branch December 26, 2020 15:50
vaibhav016 pushed a commit to vaibhav016/gpt-neox that referenced this pull request Jun 27, 2024
@bentherien
Merge pull request EleutherAI#10 from EleutherAI/summit-neox-v2.0
3c14fec 
Fixed AnnealingLR Class and Cosine Decay Schedule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StellaAthena StellaAthena StellaAthena approved these changes

@lucidrains lucidrains Awaiting requested review from lucidrains

@AranKomat AranKomat Awaiting requested review from AranKomat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate DeepSpeed
2 participants
@sdtblck @StellaAthena