Make conversion scripts compatible with Python 3.8 #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StellaAthena
reviewed
Apr 9, 2023
|
PR updated and tested for different cases! Note that the way we specified precision in DeeperSpeed v1.0 diverges from the upstream Deepspeed docs, I think( can look further though?), and so these two scripts diverge at this conditional. |
|
I'm happy with this. Merging. |
Quentin-Anthony
approved these changes
Apr 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #875 , and also improves error handling on FP16 detection for config YAMLs being converted.