1.0 HF conversion script fails on Python 3.8

[syskn]

Describe the bug

While the official recommended Python version for NeoX is 3.8, convert_v1.0_to_hf.py only works with Python 3.9 or later due to minor incompatibility (tested on Python 3.8.10).

TypeError: 'type' object is not subscriptable

Suggested change

Modify list[torch.Tensor] at the line 42 to List[torch.Tensor] (capitalized L)
Add import from typing import List

[cateto]

same here.

will it merge to main branch?

[haileyschoelkopf]

Hi, this should be fixed in #877 --can you share what commit you experience this error in?

[cateto]

@haileyschoelkopf sure!
3719533

[StellaAthena]

@cateto Try checking out the fix-convert-py3.8 branch and see if that works.

[haileyschoelkopf]

It looks like this got reverted in 29b968d by merge conflicts accidentally, I’ll re-fix this as soon as I’m back to a computer!

[cateto]

thank you 😸

[haileyschoelkopf]

This is fixed in #931 !