Skip to content

Commit

Permalink
moved eval import and added to docs (#1139)
Browse files Browse the repository at this point in the history
  • Loading branch information
R0n12 committed Jan 30, 2024
1 parent e5602c3 commit 1c133bf
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
9 changes: 5 additions & 4 deletions configs/neox_arguments.md
Original file line number Diff line number Diff line change
Expand Up @@ -976,7 +976,7 @@ Text Generation arguments

- **prompt_end**: str

Default =
Default =


a single prompt's end. Defaults to newline
Expand Down Expand Up @@ -1018,7 +1018,7 @@ Text Generation arguments

- **eval_results_prefix**: str

Default =
Default =

prefix to which to save evaluation results - final fp will be {eval_results_prefix}_eval_results_yy-mm-dd-HH-MM.json

Expand All @@ -1030,6 +1030,8 @@ Text Generation arguments

Tasks to evaluate on using lm_eval_harness

NOTE: Requires internet connection



## NeoXArgsTokenizer
Expand Down Expand Up @@ -1768,7 +1770,7 @@ Args for deepspeed config

Default = None





Expand Down Expand Up @@ -2068,4 +2070,3 @@ Args for deepspeed runner (deepspeed.launcher.runner).
Default = None

Adds a `--account` to the DeepSpeed launch command. In DeeperSpeed this is passed on to the SlurmLauncher as well. Sometimes necessary for cluster rules, or so I've heard.

3 changes: 2 additions & 1 deletion megatron/training.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
CharCounter,
)
from megatron.model.gpt2_model import cross_entropy
from eval_tasks import run_eval_harness


def mup_weights_reinit(neox_args, model):
Expand Down Expand Up @@ -967,6 +966,8 @@ def evaluate(
)

if neox_args.eval_tasks:
from eval_tasks import run_eval_harness

eval_results.update(
run_eval_harness(
model, forward_step_fn, neox_args, eval_tasks=neox_args.eval_tasks
Expand Down

0 comments on commit 1c133bf

Please sign in to comment.