Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature eval #89

Merged
merged 112 commits into from
Mar 12, 2023
Merged

Feature eval #89

merged 112 commits into from
Mar 12, 2023

Conversation

lauritowal
Copy link
Collaborator

@lauritowal lauritowal commented Feb 18, 2023 •
edited
Loading

I created an own pull request from the eval which was part of the sweep pull request.

(I am not evaluating LR, but we could add this in another PR, if needed)

norabelrose and others added 30 commits February 13, 2023 17:35
@norabelrose
Initial implementation of semi-supervised training
3a97312
@norabelrose
Full DDP support
421996c
@norabelrose
Bug fixes
2cadb28
@FabienRoger
Add .item() where necessary
bd34f96
@FabienRoger
Use maybe all gather instead of cat
522b95a
@FabienRoger
Shuffle before sharding
7f1b5af
@FabienRoger
Fix typing problems
73f4fd5
@norabelrose
Revert Fabien's change to shuffle/shard ordering
21272cf
@FabienRoger
Send labels to cpu before Linear Regression
47a6c76
@FabienRoger
Revert "Send labels to cpu before Linear Regression"
63848ba 
This reverts commit 47a6c76.
@norabelrose
Update README for multi-gpu
83ce2a8
@norabelrose
Fix README typo
51d7b19
@norabelrose
First shuffle, then select max_examples examples
ba9a0d2
@norabelrose
Fix the fix to the typo
fdc94a2
@norabelrose
Add --supervised-weight cli arg
ba91ba4
@lauritowal
add initial sweep empty function...
be8409c
@lauritowal
Merge branch 'semi-supervised' into feature_sweep
95dcde7
@lauritowal
add initial eval and swipe functions
8b5d9f5
@lauritowal
add initial eval + sweep functions
5c866a3
@lauritowal
Merge branch 'feature_sweep' of https://github.com/EleutherAI/elk int…
9fe9b85 
…o feature_sweep
@lauritowal
Merge branch 'main' into feature_sweep
f27ef1b
@lauritowal
remove breakpoint
f38b91c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
cef2b61 
for more information, see https://pre-commit.ci
@lauritowal
pre-commit cleanup
23a4c05
@lauritowal
Merge branch 'feature_sweep' of https://github.com/EleutherAI/elk int…
38519dc 
…o feature_sweep
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0e05b9b 
for more information, see https://pre-commit.ci
@AlexWan0
load dset
608bbc7
@lauritowal
replace paths w/ experiment names for model & datasets
222ff57
@lauritowal
fix: dumb error where hidden_state is added to the stats
4980a75
@lauritowal
add additional info to eval file
06f4f98
@lauritowal lauritowal marked this pull request as draft March 3, 2023 08:44
@lauritowal lauritowal marked this pull request as ready for review March 10, 2023 04:20
norabelrose
norabelrose approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@norabelrose norabelrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that there's a lot of duplicated code here, we should probably refactor to share more code with train.py but whatever

@lauritowal lauritowal merged commit ab729c4 into main Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norabelrose norabelrose norabelrose approved these changes

@AlexTMallen AlexTMallen Awaiting requested review from AlexTMallen

@FabienRoger FabienRoger Awaiting requested review from FabienRoger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lauritowal @norabelrose @FabienRoger @AlexWan0 @AlexTMallen