Train reporters for different layers in parallel #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
AlexTMallen
reviewed
Feb 19, 2023
lauritowal
reviewed
Feb 19, 2023
elk/extraction/extraction_main.py
Outdated
| extract(args, "train") | ||
| maybe_barrier() | ||
| print("wow") |
There was a problem hiding this comment.
I guess the wow thing shoudld be removed (?)
There was a problem hiding this comment.
oh sorry that was a stupid debugging thing LOL
elk/extraction/extraction_main.py
Outdated
| extract(args, "validation") | ||
|
|
||
| if rank == 0: | ||
| print("hi") |
| @@ -19,8 +19,11 @@ def list_runs(args): | |||
| ) | |||
| for timestamp, run in subfolders: | |||
| # Read the arguments used to run this experiment | |||
| with open(run / "args.json", "r") as f: | |||
| run_args = json.load(f) | |||
| try: | |||
There was a problem hiding this comment.
Isn't it cleaner to check for the file with an if instead of using a try / except and then continue?
There was a problem hiding this comment.
The reason I did it this way is that args.json really should exist, it's an anomaly if it doesn't exist. Arguably we should be indicating the error somewhere but elk list is going to change a lot soon anyway so I can't be bothered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64, based on draft PR #82