Remove redundant 'elk train' command #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauritowal
reviewed
Feb 17, 2023
| @@ -1,6 +1,6 @@ | |||
| """Main entry point for `elk`.""" | |||
|
|
|||
| from .argparsers import get_extraction_parser, get_training_parser | |||
| from .argparsers import add_train_args, get_extraction_parser | |||
There was a problem hiding this comment.
we probably want to also rename add_train_args to add_elicit_args everywhere?
There was a problem hiding this comment.
I think it's fine right now because add_train_args does add the arguments relevant to training. Arguably that whole function could be deleted and moved over into __main__.py, but I think I like the current layout slightly better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no context in which you would want to use
elk trainoverelk elicit, and having the two commands around simply makes things more confusing.