Feature balance #56
Merged
Feature balance #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…nto feature_balance
for more information, see https://pre-commit.ci
norabelrose
requested changes
Feb 12, 2023
| ) | ||
| ) | ||
|
|
||
| return concatenate_datasets(subsets).shuffle() |
There was a problem hiding this comment.
We should probably support setting the shuffle seed here
elk/extraction/prompt_collator.py
Outdated
| self.labels, counts = np.unique(self.dataset[label_column], return_counts=True) | ||
| self.label_fracs = counts / counts.sum() | ||
|
|
||
| print(f"Class balance '{split}': {[f'{x:.2%}' for x in self.label_fracs]}") | ||
| if self.label_fracs[0] != self.label_fracs[1]: |
There was a problem hiding this comment.
This isn't robust in the case where len(self.label_fracs) > 2. You could instead do:
pivot, *rest = self.label_fracs
if not all(x == pivot for x in rest):
print("Use arg --balance to force class balance")
It's also a little unclear if we want to print this for cases of near class balance, like 51% to 49% or something. But to keep the code simple I'm fine with doing this weird floating point equality thing for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.