Remove TrainParams #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauritowal
reviewed
Feb 12, 2023
| @@ -141,31 +118,29 @@ def fit( | |||
| if verbose: | |||
There was a problem hiding this comment.
Should we maybe remove verbose also from the css class, and just always print the things under the ifs ?
There was a problem hiding this comment.
Hmm I think we should either keep verbose or never print, because I want to support programmatic uses where you may not want to print every time you call fit. Like imagine if PyTorch optimizers always printed when you initialized them or called step or something.
lauritowal
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the training code a little bit, removing an internal dataclass