Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure GitHub Actions CI For CPU Tests #53

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Conversation

Kyle1668
Copy link
Contributor

Closes #39

@Kyle1668 Kyle1668 self-assigned this Feb 10, 2023
@Kyle1668 Kyle1668 changed the title [Draft] Configure GitHub Actions CI For CPU Tests Configure GitHub Actions CI For CPU Tests Feb 10, 2023
@@ -0,0 +1,42 @@
name: "Run CPU Tests"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read that Actions has composites where we can make this more DRY. I don't think it's currently necessary with how simple this pipeline is.

Copy link
Member

@norabelrose norabelrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly it seems like you know more about GH Actions than I do so I'm content to merge this and see what happens. AFAICT there's no simple way to test the actions before merging. If needed we can revert it.

@Kyle1668
Copy link
Contributor Author

@norabelrose Thanks for the review! The updated actions automatically run in the branch where these edits are made. See the checks tab of the PR.

image

I didn't in this case, but if I'm less certain about the changes I;m making and want a faster feedback loop, I use the act CLI tool. This tool runs the actions in a local Docker container and is pretty easy to use.

@Kyle1668 Kyle1668 merged commit da4e023 into main Feb 13, 2023
@Kyle1668 Kyle1668 deleted the github-cpu-actions branch February 13, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create GitHub Actions CI Pipeline for CPU Tests
2 participants