Move changes over from mother-of-all-refactors #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extraction-refactor
lauritowal
approved these changes
Feb 9, 2023
| # Token used to separate the question from the answer | ||
| sep_token = tokenizer.sep_token or "\n" | ||
|
|
||
| # TODO: Maybe also make this configurable? |
There was a problem hiding this comment.
Should we have the option to discard too, as it was in the original code?
There was a problem hiding this comment.
Made an issue #47 and assigned it to you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sort of a "lite" version of the much larger "mother of all refactors" PR that focuses on changes to the hidden state extraction code. It also includes the refactor of the CLI to allow for commands like
elk extract.