Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom run name for train & eval #42

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Add custom run name for train & eval #42

merged 3 commits into from
Feb 9, 2023

Conversation

FabienRoger
Copy link
Collaborator

@FabienRoger FabienRoger commented Feb 7, 2023 •
edited
Loading

Add the --run-name flag. Fix #35

Also add a tiny bug fix

norabelrose
norabelrose approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@norabelrose norabelrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norabelrose norabelrose merged commit 7735940 into main Feb 9, 2023
@norabelrose norabelrose deleted the custom-names-for-train-eval branch February 12, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norabelrose norabelrose norabelrose approved these changes

@lauritowal lauritowal Awaiting requested review from lauritowal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use better filenames for the pkls so they don't get overwritten
2 participants
@FabienRoger @norabelrose