Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce Dashes in CLI Argument Names #38

Merged
merged 8 commits into from
Feb 4, 2023
Merged

Enforce Dashes in CLI Argument Names #38

merged 8 commits into from
Feb 4, 2023

Conversation

Kyle1668
Copy link
Contributor

@Kyle1668 Kyle1668 commented Feb 4, 2023

Closes #15

norabelrose
norabelrose requested changes Feb 4, 2023
View reviewed changes
Copy link
Member

@norabelrose norabelrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go I think, just need to rename the tests and remove the trained CCS model from Git

elk/tests/utils_evaluation/test_eval_parser.py Outdated Show resolved Hide resolved
elk/tests/utils_generation/test_gen_parser.py Outdated Show resolved Hide resolved
norabelrose
norabelrose approved these changes Feb 4, 2023
View reviewed changes
Copy link
Member

@norabelrose norabelrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norabelrose norabelrose merged commit e87da87 into main Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norabelrose norabelrose norabelrose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change CLI args to use dashes, not underscores
2 participants
@Kyle1668 @norabelrose