Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all HF models #31

Merged
merged 38 commits into from
Feb 9, 2023
Merged

Support all HF models #31

merged 38 commits into from
Feb 9, 2023

Conversation

neverix
Copy link
Member

@neverix neverix commented Feb 3, 2023

This PR removes checks for the model list and changes the config format.

@lauritowal lauritowal self-requested a review February 3, 2023 19:43
elk/utils_evaluation/parser.py Outdated Show resolved Hide resolved
elk/utils_evaluation/utils_evaluation.py Show resolved Hide resolved
elk/default_config.json Show resolved Hide resolved
@norabelrose
Copy link
Member

I fixed some unbound variable errors. Also I couldn't help myself and went ahead and fixed #25 because it was annoying me.

@norabelrose norabelrose force-pushed the all-the-models branch 2 times, most recently from 47f6f29 to 19a0f21 Compare February 4, 2023 20:17
@lauritowal
Copy link
Collaborator

lauritowal commented Feb 4, 2023

For Deberta I get the following error:

Traceback (most recent call last):
  File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/wombat_share/laurito/elk/elk/generation_main.py", line 55, in <module>
    create_hiddenstates(model, tokenizer, name_to_dataframe, args)
  File "/home/wombat_share/laurito/elk/elk/utils_generation/generation.py", line 108, in create_hiddenstates
    hidden_states = calculate_hidden_state(
  File "/home/wombat_share/laurito/elk/elk/utils_generation/generation.py", line 28, in calculate_hidden_state
    assert (
AssertionError: BERT does not have decoder. Relevant args: model=microsoft/deberta-v2-xxlarge-mnli, states_location=decoder.

@neverix

@norabelrose norabelrose merged commit 06be5e5 into main Feb 9, 2023
@norabelrose norabelrose deleted the all-the-models branch February 12, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants