Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transfer plot bug #280

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Fix transfer plot bug #280

merged 2 commits into from
Jul 31, 2023

Conversation

reaganjlee
Copy link
Collaborator

Previously, elk would go through transfer_dir to find eval.csv files instead of how it responsively finds csv files like in train_dir, which this fixes. This also renames the get_train_dirs to be more clear when using it in both directory situations

@reaganjlee reaganjlee changed the title Bug plot dir Fix transfer plot bug Jul 25, 2023
@derpyplops
Copy link
Collaborator

LGTM!

@lauritowal lauritowal merged commit ab7c504 into main Jul 31, 2023
6 checks passed
@lauritowal lauritowal deleted the bug_plot_dir branch July 31, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauritowal lauritowal lauritowal approved these changes

@derpyplops derpyplops Awaiting requested review from derpyplops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reaganjlee @derpyplops @lauritowal