Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug with encoder only models not expecting "labels" argument in forward pass #264

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Fixed bug with encoder only models not expecting "labels" argument in forward pass #264

merged 3 commits into from
Jun 29, 2023

Conversation

AugustasMacijauskas
Copy link
Collaborator

@AugustasMacijauskas AugustasMacijauskas commented Jun 27, 2023 •
edited
Loading

After fixing, I tested with:

  • microsoft/deberta-v2-xxlarge
  • allenai/unifiedqa-v2-t5-11b-1363200 (whole model)
  • allenai/unifiedqa-v2-t5-11b-1363200 (with --use_encoder_states)

All of them seemed to work as expected.

@AugustasMacijauskas AugustasMacijauskas linked an issue Jun 27, 2023 that may be closed by this pull request
Encoder-only models do not expect labels argument to be passed to forward #262
Closed
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AugustasMacijauskas AugustasMacijauskas changed the title Fixed bug with encoder only models not expecting "labels" argument in…. Fixed bug with encoder only models not expecting "labels" argument in forward pass Jun 27, 2023
@AugustasMacijauskas AugustasMacijauskas self-assigned this Jun 27, 2023
@artkpv
Copy link
Contributor

artkpv commented Jun 28, 2023

Works for me with elk elicit allenai/unifiedqa-t5-base imdb --net ccs (code at https://github.com/artkpv/elk/tree/pipenv-files)

@AugustasMacijauskas
Copy link
Collaborator Author

@artkpv Have you also tested with --use_encoder_states because that is what initially caused the issue for me?

norabelrose
norabelrose approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@norabelrose norabelrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the bugfix

@norabelrose norabelrose merged commit 4ec2289 into main Jun 29, 2023
6 checks passed
@norabelrose norabelrose deleted the fix/use_encoder_states branch June 29, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norabelrose norabelrose norabelrose approved these changes

Assignees

@AugustasMacijauskas AugustasMacijauskas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encoder-only models do not expect labels argument to be passed to forward
4 participants
@AugustasMacijauskas @CLAassistant @artkpv @norabelrose